Skip to content

[pq] restore rtmr/CT_PERS_QUEUE compatibility #17977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[pq] restore rtmr/CT_PERS_QUEUE compatibility #17977

wants to merge 3 commits into from
+33 −5

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented May 4, 2025 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Only needed for RTMR compatibility.
Actually, dq_pq_{read,write} are not used in rtmr, only discovery needs to be supported, they are changed to avoid confusing incompatibility

@yumkam yumkam requested review from alexnick88 and uzhastik May 4, 2025 08:11
@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2025 •
edited
Loading

🟢 2025-05-06 16:32:00 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2025 •
edited
Loading

⚪ 2025-05-04 08:14:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for afe17ac has started.
⚪ 2025-05-04 08:15:01 UTC Artifacts will be uploaded here
⚪ 2025-05-04 08:17:45 UTC ya make is running...
🟡 2025-05-04 09:26:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27714 25049 0 1 2633 31

⚪ 2025-05-04 09:28:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-04 09:41:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
141 (only retried tests) 110 0 1 0 30

⚪ 2025-05-04 09:41:34 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-05-04 10:05:05 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
108 (only retried tests) 77 0 0 2 29

🟢 2025-05-04 10:05:12 UTC Build successful.
🟢 2025-05-04 10:05:32 UTC ydbd size 2.2 GiB changed* by +25.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6b63276 merge: afe17ac diff diff %
ydbd size 2 343 463 240 Bytes 2 343 488 872 Bytes +25.0 KiB +0.001%
ydbd stripped size 492 773 824 Bytes 492 778 752 Bytes +4.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2025 •
edited
Loading

⚪ 2025-05-04 08:14:51 UTC Pre-commit check linux-x86_64-release-asan for afe17ac has started.
⚪ 2025-05-04 08:15:02 UTC Artifacts will be uploaded here
⚪ 2025-05-04 08:17:50 UTC ya make is running...
🟡 2025-05-04 09:42:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12936 12782 0 83 48 23

⚪ 2025-05-04 09:43:59 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-04 10:13:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
975 (only retried tests) 861 0 54 38 22

⚪ 2025-05-04 10:13:47 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-04 10:37:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
793 (only retried tests) 680 0 53 39 21

🟢 2025-05-04 10:37:14 UTC Build successful.
🟢 2025-05-04 10:37:46 UTC ydbd size 3.8 GiB changed* by +34.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6b63276 merge: afe17ac diff diff %
ydbd size 4 122 620 728 Bytes 4 122 656 216 Bytes +34.7 KiB +0.001%
ydbd stripped size 1 429 181 144 Bytes 1 429 189 848 Bytes +8.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam changed the title [WIP][pq][federation] add CT_PERS_QUEUE compatibility [WIP][pq][federation] restore CT_PERS_QUEUE compatibility May 4, 2025
@yumkam yumkam removed the request for review from alexnick88 May 6, 2025 16:23
@yumkam yumkam changed the title [WIP][pq][federation] restore CT_PERS_QUEUE compatibility [pq] restore rtmr/CT_PERS_QUEUE compatibility May 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

⚪ 2025-05-06 16:26:31 UTC Pre-commit check linux-x86_64-release-asan for b829444 has started.
⚪ 2025-05-06 16:26:43 UTC Artifacts will be uploaded here
⚪ 2025-05-06 16:29:38 UTC ya make is running...
🟡 2025-05-06 18:09:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12950 12792 0 92 41 25

⚪ 2025-05-06 18:10:32 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-06 18:46:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1435 (only retried tests) 1303 0 70 38 24

⚪ 2025-05-06 18:46:52 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-06 19:19:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1369 (only retried tests) 1256 0 53 37 23

🟢 2025-05-06 19:20:13 UTC Build successful.
🟢 2025-05-06 19:20:45 UTC ydbd size 3.8 GiB changed* by -1.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 97ed61a merge: b829444 diff diff %
ydbd size 4 127 606 216 Bytes 4 126 401 776 Bytes -1.1 MiB -0.029%
ydbd stripped size 1 433 427 832 Bytes 1 432 987 064 Bytes -430.4 KiB -0.031%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

⚪ 2025-05-06 16:33:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for b829444 has started.
⚪ 2025-05-06 16:34:03 UTC Artifacts will be uploaded here
⚪ 2025-05-06 16:37:13 UTC ya make is running...
🟡 2025-05-06 18:15:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27742 25048 0 5 2643 46

⚪ 2025-05-06 18:18:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-06 18:34:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
643 (only retried tests) 602 0 1 2 38

⚪ 2025-05-06 18:35:02 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-05-06 18:49:52 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
542 (only retried tests) 508 0 0 0 34

🟢 2025-05-06 18:50:03 UTC Build successful.
🟢 2025-05-06 18:50:42 UTC ydbd size 2.2 GiB changed* by +32.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ffb86c1 merge: b829444 diff diff %
ydbd size 2 343 592 920 Bytes 2 343 625 872 Bytes +32.2 KiB +0.001%
ydbd stripped size 493 018 176 Bytes 493 023 616 Bytes +5.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam marked this pull request as ready for review May 7, 2025 09:47
@yumkam yumkam requested a review from a team as a code owner May 7, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzhastik uzhastik Awaiting requested review from uzhastik

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yumkam